Fix asymmetric behavior of scroll direction #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for your good point! The only thing I'm worried about is the size increase due to division. |
Collaborator
|
I confirmed this increases 62 bytes. Are there any good tricks to reduce this? |
Collaborator
|
I fix this to reduce size in #507 |
Collaborator
|
I merged this with #507. Thank you |
Contributor
Author
|
Thank YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the scroll div is sufficiently large, you'll see a weird asymmetric behavior of scrolling; when you scroll towards the positive direction, the actual scroll happens after some ball movement, but when you scroll towards the negative direction, the scroll happens with a little ball movement.
This happens because the behavior of right shift
>> divis not symmetric for positive and negative lhs. For example,1 >> 3is zero, but-1 >> 3is-1. https://wandbox.org/permlink/M943OJ3soMrS4uH6This PR fixes the issue by using division
/ (1 << div)instead, which truncates result towards zero.