Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@the-phinet
Copy link
Contributor

No description provided.

@the-phinet the-phinet changed the title Silence a number of nontrivial-memcall warnings Fixup nontrivial memcall warning Aug 9, 2025
@RicardoLuis0
Copy link
Contributor

RicardoLuis0 commented Aug 10, 2025

this should probably be fixed where possible rather than simply muted, silencing these warnings can lead to ingoring actual memory corruption (even though most of them are false positives, ex. a std::pair of trivial types not being counted as trivial in and of itself)

@the-phinet
Copy link
Contributor Author

the-phinet commented Aug 10, 2025

Crap sorry, I thought that the explicit void* cast was a trivial and correct fix. Should I leave this open for you to look at, or close it?

@RicardoLuis0
Copy link
Contributor

the issue is that classes with constructors/destructors can't be simply copied memcpy, and that's why the warning is there, for the cases where the warning is a false positive, a cast is fine, but all cases of the warning should be properly looked at

@the-phinet
Copy link
Contributor Author

Ahh, that makes sense. Thanks. I'll take a look and only keep the ones I know are okay

@the-phinet the-phinet marked this pull request as draft August 11, 2025 16:50
@the-phinet the-phinet marked this pull request as ready for review August 15, 2025 18:33
@the-phinet the-phinet changed the title Fixup nontrivial memcall warning [NIT] Fixup nontrivial memcall warning Aug 31, 2025
@the-phinet the-phinet changed the title [NIT] Fixup nontrivial memcall warning [Nit] Fixup nontrivial memcall warning Aug 31, 2025
@RicardoLuis0 RicardoLuis0 merged commit e2bd23d into ZDoom:master Sep 19, 2025
10 checks passed
@the-phinet the-phinet deleted the shhhhh branch September 19, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants