-
Notifications
You must be signed in to change notification settings - Fork 623
[Nit] Fixup nontrivial memcall warning #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
this should probably be fixed where possible rather than simply muted, silencing these warnings can lead to ingoring actual memory corruption (even though most of them are false positives, ex. a std::pair of trivial types not being counted as trivial in and of itself) |
|
Crap sorry, I thought that the explicit void* cast was a trivial and correct fix. Should I leave this open for you to look at, or close it? |
|
the issue is that classes with constructors/destructors can't be simply copied memcpy, and that's why the warning is there, for the cases where the warning is a false positive, a cast is fine, but all cases of the warning should be properly looked at |
|
Ahh, that makes sense. Thanks. I'll take a look and only keep the ones I know are okay |
No description provided.