You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflections in beat saber can look wrong when running with monado + openvr translator
Implementation
I tried to use the launch options menu to customize this at first but couldn't get it to work. Since OXR_PARALLEL_VIEWS only affect canted views headsets and only recognized by Monado, it should be safe to set by default and not affect other headset/setups.
How to Test
Need a headset with canted views like the Index and run with monado, reflections should look cross-eyed by default and with this change it should look correct.
Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
🟢 Nice refactor!
🟡 Why was the default value removed?
E.g: Blocking feedback must be addressed before merging.
@tleydxdy Is it possible to create a launch options button for this instead, rather than setting it defaultly to all linux systems (since not all uses monado as their runtime). Would probably suggest to add it as a default button here (the button label is like "Monado" or something specific to the OXR_PARALLEL_VIEWS env var).
Yeah I can try that, although since this envvar only have an effect on monado, I don't think it would be a problem to just always set it so it works ootb.
@tleydxdy If thats the case, no issue. Just a minor comment on abstract-launcher.service.ts to add a comment that the env var is monado specific as well and Im all goods with the PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://gitlab.freedesktop.org/monado/monado/-/merge_requests/2312
Scope
Reflections in beat saber can look wrong when running with monado + openvr translator
Implementation
I tried to use the launch options menu to customize this at first but couldn't get it to work. Since OXR_PARALLEL_VIEWS only affect canted views headsets and only recognized by Monado, it should be safe to set by default and not affect other headset/setups.
How to Test
Need a headset with canted views like the Index and run with monado, reflections should look cross-eyed by default and with this change it should look correct.
Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
E.g: Blocking feedback must be addressed before merging.