Support different fields for each key #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgwood
reviewed
Sep 18, 2020
| const filterList = (typeof filter === "string" | ||
| ? [filter] | ||
| : filter | ||
| ).map((filter) => renderTemplate(filter, alibeezParams)); |
Member
There was a problem hiding this comment.
Only filters are rendered now? Do you think it is enough? Also this is not obvious when writing the config. I'm not convinced about this change, especially since it seems to be out of scope with this PR.
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure you told me we would never let the user choose for the fields they request because it can be abused, and I think it's a good thing.
hgwood
reviewed
Sep 18, 2020
| escape as escapeQuerystring, | ||
| } from "querystring"; | ||
| import { parse as parseQuerystring } from "querystring"; | ||
| import { parse as parseUrl } from "url"; |
Member
There was a problem hiding this comment.
Isn't this the one that's deprecated?
Contributor
Author
There was a problem hiding this comment.
It's in the the same module, see https://nodejs.org/api/url.html#url_url
Member
|
Replaced by #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.