Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Build regex from channel and not sub->channel. #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbendes merged 1 commit into from
Nov 17, 2025
Merged

Build regex from channel and not sub->channel. #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zcm/blocking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ zcm_sub_t* zcm_blocking_t::subscribe(const string& channel,
sub->usr = usr;
sub->regex = isRegexChannel(channel);
if (sub->regex) {
sub->regexobj = (void*) new std::regex(sub->channel);
sub->regexobj = (void*) new std::regex(channel);
Copy link
Contributor Author

@patmarion patmarion Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel is the complete string. sub->channel has been truncated at ZCM_CHANNEL_MAXLEN. Note that just below here the sub is stored in a map using channel as the key.

ZCM_ASSERT(sub->regexobj);
subsRegex[channel].push_back(sub);
} else {
Expand Down
Loading