Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn about hash collisions on build #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbendes merged 1 commit into from
Nov 29, 2025
Merged

Warn about hash collisions on build #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions waftools/zcm-gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@

import os
import waflib
import json
from waflib import Task
from waflib import Utils
from waflib import Logs
from waflib.Errors import WafError
from waflib.TaskGen import extension
from waflib.Configure import conf
Expand Down Expand Up @@ -178,6 +180,22 @@ def outFileNames(ctx, bldpath, inFile, **kw):

return files

def getTypeHashes(ctx, inFile):
zcmgen = ctx.env['ZCMGEN']

raw = ctx.cmd_and_log('zcm-gen -d %s' % (inFile),
output=waflib.Context.STDOUT,
quiet=waflib.Context.BOTH).strip()
data = json.loads(raw)
results = [
[
entry["structname"]["fullname"],
str(entry["hash"]),
]
for entry in data.values()
]
return results

def genJuliaPkgFiles(task):
gen = task.generator

Expand Down Expand Up @@ -265,7 +283,15 @@ def zcmgen(ctx, **kw):
cppStdArray = cppStdArray,
juliapkg = juliapkg,
javapkg = javapkg)
allTypeHashes = {}
for s in tg.source:
typeHashes = getTypeHashes(ctx, s)
for [tName, tHash] in typeHashes:
if tHash in allTypeHashes:
Logs.warn(('WARNING: %s and %s have the same hash. ' +
'You probably do not want this.')
% (allTypeHashes[tHash], tName))
allTypeHashes[tHash] = tName
ctx.add_manual_dependency(s, zcmgen)

if 'cpp' in lang:
Expand Down
Loading