fix: use productID to detect ledger type #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue on certain linux hosts when strings are not decoded properly. though strings issue must be fixed, it is still remains convenient to ProductID as source of detection Ledger type Signed-off-by: Artur Troian <[email protected]>
|
/cc @jleni |
jleni
approved these changes
Apr 7, 2021
jleni
reviewed
Apr 7, 2021
|
|
||
| // list of supported product ids as well as their corresponding interfaces | ||
| var supportedLedgerProductID = map[uint16]int{ | ||
| 0x4011: 0, // Ledger Nano X |
There was a problem hiding this comment.
The problem with this is that in the past, these values have changed according to the firmware version.
While they are supposed to be stable in the future, we should keep an eye on them in case there are any breaking changes.
There was a problem hiding this comment.
Should be pretty easy to add new/updated values. String neither remain stable within product. Pid change is rather exceptional case imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue on certain linux hosts when strings are not
decoded properly. though strings issue must be fixed,
it is still remains convenient to ProductID as source
of detection Ledger type
Signed-off-by: Artur Troian [email protected]