Don't return err when parsemode is permissive #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a duplicate of #479? |
|
Not exactly a duplicate, I’d say this is complementary to #479. In my pull request, I introduced granular permissive handling within individual parsers, whereas this provides a higher-level safety net for cases that remain uncovered |
|
needs rustfmt |
Done |
|
@Kharosx0 this needs a rebase now; after that let's re-review now that permissive stuff has landed. You may be able to use the new trait to help with this, not sure. |
|
@Kharosx0 are you still interested in this? If so, can you checkout the latest goblin, and see if the new parsemode permissive changes are working like your PR, as they may already be implementing this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore more errors and continue parsing when ParseMode is Permissive (e.g. an erroneous resource directory should not prevent parsing of the PE when ParseMode is Permissive).