Support Ingestion Routing Policy #4378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredtsun
approved these changes
Sep 23, 2025
1733e82 to
3ca53d9
Compare
89e27a1 to
40faf1a
Compare
fredtsun
reviewed
Sep 30, 2025
| RoutingPolicy policy.RoutingPolicy `json:"routingPolicy,omitempty"` | ||
| } | ||
|
|
||
| func (m PipelineMetadata) String() string { |
There was a problem hiding this comment.
just noticed when i was debugging, can we add RoutingPolicy to this as well? (the String() func)
d395eed to
ef59441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Today m3msg supports multiple ways to filter msgs towards the consumer services:
These are not flexible enough to select a customized subset of metrics to filter. We will define another field in the PipelineMetadata struct called
RoutingPolicywhich will capture the traffic type for that metric. This way a consumer can register interest in the traffic types and receive only those metrics.A strict design goal choice for this feature is that it be backwards compatible. i.e. Any existing use of filters and consumer services will not be modified.
The RoutingPolicy should be set in the metric metadata when sending over the aggregator-client.
This PR only plumbs the routingPolicy through the aggregator path without performing the actual filtering on the m3msg end. There will be a subsequent diff that adds this filtering support.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: