[coordinator] Use runServer in all tests in query_test.go #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antanukas
commented
Sep 23, 2021
| go func() { | ||
| asyncDownsampler.Lock() | ||
| defer asyncDownsampler.Unlock() | ||
|
|
There was a problem hiding this comment.
without this change TestGRPCBackend fails with nil pointer panic.
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
======================================
Coverage 56.9% 56.9%
======================================
Files 552 552
Lines 63007 63007
======================================
Hits 35896 35896
Misses 23925 23925
Partials 3186 3186
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vpranckaitis
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Small refactor to query_test.go to use runServer helper to remove some duplicated test code. I have started using MemStore instead of mocked one. It seems it might have revealed race condition in asyncDownsampler constructor that I fixed by moving lock.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: