Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tests] Add m3msg and agg placement admin functionalities to In-process Coordinator #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2021
Merged

[tests] Add m3msg and agg placement admin functionalities to In-process Coordinator #3786

merged 7 commits into from
Sep 29, 2021

Conversation

fishie9
Copy link
Collaborator

@fishie9 fishie9 commented Sep 28, 2021

What this PR does / why we need it:

This PR adds some admin functions to the in-process coordinators, so they can manage m3msg topics and aggregator placements.
In-process aggregators will be implemented based on this change.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ wesleyk
✅ fishie9
❌ Siyu Yang

Siyu Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #3786 (f23f395) into master (f23f395) will not change coverage.
The diff coverage is n/a.

❗ Current head f23f395 differs from pull request most recent head b2fcfcd. Consider uploading reports for the commit b2fcfcd to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3786   +/-   ##
======================================
  Coverage    57.0%   57.0%           
======================================
  Files         552     552           
  Lines       63014   63014           
======================================
  Hits        35967   35967           
  Misses      23854   23854           
  Partials     3193    3193
Flag Coverage Δ
aggregator 63.3% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.7% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23f395...b2fcfcd. Read the comment docs.

@fishie9 fishie9 requested a review from nbroyles September 28, 2021 01:32
nbroyles
nbroyles reviewed Sep 28, 2021
View reviewed changes
@fishie9 fishie9 requested a review from nbroyles September 28, 2021 19:21
@fishie9 fishie9 merged commit 11f633f into master Sep 29, 2021
@fishie9 fishie9 deleted the siyu/m3msg branch September 29, 2021 01:16
Antanukas pushed a commit that referenced this pull request Oct 5, 2021
@fishie9 @wesleyk @Antanukas
[tests] Add m3msg and agg placement admin functionalities to In-proce…
28f5a6e 
…ss Coordinator (#3786)

This PR adds some admin functions to the in-process coordinators, so they can manage m3msg topics and aggregator placements.
In-process aggregators will be implemented based on this change.

Co-authored-by: Wesley Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbroyles nbroyles nbroyles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fishie9 @CLAassistant @nbroyles @wesleyk