-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for shared settings #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
|
Then give me the green flag to merge 👍 |
While I think it is good for merge I would still actually like to first see real use case for this. Do you have some simple actual use case for it, maybe something you could even show off a bit with simple code? I mean just basics for syncing some real configuration. I do not mean user interfaces or anything like that but one configuration key/value that would make sense when synced across mods. |
It is used to be a prerequisite to beerchat muting. I'll first implementing it then you will be able to try from the spam features merge request. |
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
b6eaa98 to
e75e46d
Compare
Co-authored-by: SX <[email protected]>
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
e75e46d to
fd42f00
Compare
BuckarooBanzay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but why the syncing and not just read from one "single source of truth"?
Beerchat is actually a source of truth. No need for other mods currently, so I just check if beerchat is installed and then I run the script. I'm not gonna run a script for a non-existing mod. |
As the title says. It does not cause any bug with existing setting.
It is pretty simple, however in the future it might becomes a bottleneck so I open a pull request for that.