Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Athozus
Copy link
Member

@Athozus Athozus commented Dec 17, 2023

As the title says. It does not cause any bug with existing setting.

It is pretty simple, however in the future it might becomes a bottleneck so I open a pull request for that.

@Athozus Athozus added the Enhancement New feature or request label Dec 17, 2023
@Athozus Athozus added this to the 1.4.0 milestone Dec 17, 2023
Athozus added a commit that referenced this pull request Dec 18, 2023
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
@Athozus
Copy link
Member Author

Athozus commented Dec 18, 2023

Then give me the green flag to merge 👍

@S-S-X
Copy link
Member

S-S-X commented Dec 18, 2023

Then give me the green flag to merge 👍

While I think it is good for merge I would still actually like to first see real use case for this.

Do you have some simple actual use case for it, maybe something you could even show off a bit with simple code? I mean just basics for syncing some real configuration.

I do not mean user interfaces or anything like that but one configuration key/value that would make sense when synced across mods.

@Athozus
Copy link
Member Author

Athozus commented Dec 18, 2023

Then give me the green flag to merge 👍

While I think it is good for merge I would still actually like to first see real use case for this.

Do you have some simple actual use case for it, maybe something you could even show off a bit with simple code? I mean just basics for syncing some real configuration.

I do not mean user interfaces or anything like that but one configuration key/value that would make sense when synced across mods.

It is used to be a prerequisite to beerchat muting. I'll first implementing it then you will be able to try from the spam features merge request.

@Athozus Athozus mentioned this pull request Dec 26, 2023
Athozus added a commit that referenced this pull request Dec 27, 2023
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
Athozus and others added 3 commits January 1, 2024 19:21
In set_setting, to eventually transfer to another mod. Suggested by S-S-X in #127
Copy link
Member

@BuckarooBanzay BuckarooBanzay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but why the syncing and not just read from one "single source of truth"?

@Athozus
Copy link
Member Author

Athozus commented Jan 13, 2024

looks good, but why the syncing and not just read from one "single source of truth"?

Beerchat is actually a source of truth. No need for other mods currently, so I just check if beerchat is installed and then I run the script. I'm not gonna run a script for a non-existing mod.

@Athozus Athozus merged commit 46012a2 into master Feb 1, 2024
@Athozus Athozus deleted the shared-settings branch April 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants