Better about page #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-S-X
approved these changes
Apr 3, 2023
Member
S-S-X
left a comment
There was a problem hiding this comment.
Seems fine, never checked that about form... so no idea how it was before but I guess table is appropriate here if including contributors.
Should it also mention code license which is MIT Expat with minor modification? I guess you probably could just call it MIT.
But anyway seems ok to me with or without license info.
Niklp09
approved these changes
Apr 3, 2023
Member
Niklp09
left a comment
There was a problem hiding this comment.
code looks good, formspec is working
Member
Author
|
Then, based on @S-S-X suggestion, I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is here to provide a better about page.
It shows :
In the future, we would add quick help in the same menu or something else.
Let me know your advice/suggestions.
Closes #52