Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@S-S-X
Copy link
Member

@S-S-X S-S-X commented Apr 8, 2023

Be aware that this PR is targeting message-sorting branch, not master branch.
Decided to make changes in separate branch to make it easier to see what would be changed.
@Athozus

Reworks mail.sort_messages(...) function to decouple it from user interface handles / formspec fields.

Function was used like this:

-- second argument sorting field, last argument is sort direction (both are formspec dropdown indexes)
local sortedmessages = mail.sort_messages(messages, "2", "2")

And after changes done here it will be used like this:

-- second argument sorting field, last argument is sort direction (ascending if true)
local sortedmessages = mail.sort_messages(messages, "subject", true)

@Athozus
Copy link
Member

Athozus commented Apr 9, 2023

Good for me, thx

@Athozus Athozus added Bug Something isn't working Enhancement New feature or request labels Apr 9, 2023
@Athozus Athozus added this to the 1.1.0 milestone Apr 9, 2023
@S-S-X
Copy link
Member Author

S-S-X commented Apr 10, 2023

Merging this, continue discussion / decision on original PR.

@S-S-X S-S-X merged commit 811bd37 into message-sorting Apr 10, 2023
@S-S-X S-S-X deleted the message-sorting-update1 branch April 10, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants