fix mail.delete_mail (again)
#99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion in #97 and #98 (the
breakjust breaks out of the inner loop, the messages still get iterated over)for example this player-entry here:
and if you want to delete messages with the following msg_id's:
The mail with id
cwill get matched first and removed, after that the inbox looks like this:But the inner loop still continues with the exact same
ivalue and tries to dereferenceinbox[3](which it does not find)The break ensures that the
iiterator value is actually sane and does point to a valid entry.