Dock/TaskBar icon status with jobs progress updates #823

pskowronek · 2022-12-26T18:25:49Z

Added FileJobs' status updates on App Icon - under macOS in Dock or in Taskbar in Windows/Ubuntu (Unity).

progress (probably not calculated accurately - probably I should use getTotalPercentDone instead of getJobProgress.getFilePercentInt)
badge number - number of jobs (all i.e. foreground and background jobs)
icon bouncing when user attention is required (file exists etc)

Screenshot:

This is PoC - only checked on macOS Catalina.

All comments are welcomed.

mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java

mucommander-core/src/main/java/com/mucommander/ui/notifier/NotifierProvider.java

ghost · 2022-12-26T19:24:08Z

On macOS Ventura, I only see a job counter, but I don't see a progress bar.
By the way, this would be a great opportunity to address #565. 😀

ahadas · 2023-01-03T22:31:27Z

interesting :) I need to take a better look at the details though

pskowronek · 2023-04-26T17:35:54Z

rebased

pskowronek · 2023-04-28T21:07:53Z

interesting :) I need to take a better look at the details though

@ahadas Can you take a look? Your input will be valuable, then I would try to prepare a proper PR.

ahadas · 2023-04-29T20:35:06Z

@ahadas Can you take a look? Your input will be valuable, then I would try to prepare a proper PR.

sure, sorry for not getting back to it sooner - I'll try to do it this week

ahadas

@pskowronek it may seems like a high number of comments but most of them are minor, this change looks nice overall - however as you commented inside, let's find the right place to have this bridge from the jobs to the icon's badge and progress

mucommander-core/src/main/java/com/mucommander/core/desktop/DesktopManager.java

mucommander-core/src/main/java/com/mucommander/job/FileJob.java

mucommander-core/src/main/java/com/mucommander/job/JobProgress.java

mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java

mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java

mucommander-os-macos/src/main/java/com/mucommander/desktop/macos/OSXDesktopAdapter.java

pskowronek · 2023-05-06T12:00:51Z

PR updated to address all minor comments (that I've marked as resolved).

…ierProvider

pskowronek · 2023-05-06T21:25:52Z

PR updated - jobs listener registration moved to NotifierProvider

pskowronek · 2023-05-06T22:29:27Z

On macOS Ventura, I only see a job counter, but I don't see a progress bar. By the way, this would be a great opportunity to address #565. 😀

I've just pushed a commit with workaround for that. @Andreas0602 can you check it?

pskowronek · 2023-05-06T22:31:39Z

On macOS Ventura, I only see a job counter, but I don't see a progress bar. By the way, this would be a great opportunity to address #565. 😀

I've just pushed a commit with workaround for that. @Andreas0602 can you check it?

@ahadas / @Andreas0602 or anyone - do you have account on bugs.openjdk.org to add a comment to https://bugs.openjdk.org/browse/JDK-8300037 ?

ghost · 2023-05-06T23:02:19Z

I've just pushed a commit with workaround for that. @Andreas0602 can you check it?

In my opinion, it looks good.

Screenshot of about 99 % progress:

@ahadas / @Andreas0602 or anyone - do you have account on bugs.openjdk.org ...

No, I haven't.

ghost · 2023-05-06T23:23:03Z

By the way, here's a screenshot of the progress bar of NewsLazer at about 75 %. I must say that it looks better.

pskowronek · 2023-05-07T09:12:40Z

By the way, here's a screenshot of the progress bar of NewsLazer at about 75 %. I must say that it looks better.

ours or theirs? :)

ghost · 2023-05-07T09:14:10Z

theirs

pskowronek · 2023-05-07T09:17:40Z

Matter of taste :) However, ours is a native one, and theirs is custom painted and updated icon.

…via Taskbar

ahadas · 2023-05-08T20:39:20Z

jre

need to drop this change

I should remove it from PR, right?

hmm, this is submodule... any hint how to revert it?

I've pushed a commit that reverts that change. it seems like the 'jre' submodule is not up-to-date, did you try git submodule update?

hm, it does nothing, the same with git submodule init. Previously I also tried git submodule foreach git reset --hard - it did something, but..... heck, still I don't know how come it went to commit and how it should be reverted.

ah yeah, actually it means the submodule was updated because otherwise it would't have detected a change in 'jre' - did you rebase the root repo? it seems like you are missing this commit

ahadas

minor comments, other than that lgtm

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java

package/readme.txt

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java

ahadas · 2023-05-08T21:11:24Z

@ahadas / @Andreas0602 or anyone - do you have account on bugs.openjdk.org ...

No, I haven't.

me neither

pskowronek · 2023-05-08T22:02:20Z

PR updated

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java

ahadas

thanks @pskowronek !
note that I commented on the 'jre' thread - I think you just need to update the submodule with git submodule update

ahadas · 2023-07-08T18:19:08Z

Version 1.3.0 that includes a fix for this issue has been released

pskowronek requested a review from ahadas as a code owner December 26, 2022 18:25

pskowronek commented Dec 26, 2022

View reviewed changes

mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java Outdated Show resolved Hide resolved

pskowronek commented Dec 26, 2022

View reviewed changes

mucommander-core/src/main/java/com/mucommander/ui/notifier/NotifierProvider.java Outdated Show resolved Hide resolved

pskowronek force-pushed the dock-icon-status-update branch from e2399fe to e34f6b8 Compare January 5, 2023 23:16

pskowronek force-pushed the dock-icon-status-update branch from e34f6b8 to 4a61cc7 Compare April 6, 2023 21:11

pskowronek force-pushed the dock-icon-status-update branch from 4a61cc7 to 3cf92b0 Compare April 26, 2023 17:35

ahadas added this to the 1.3.0 milestone Apr 29, 2023

ahadas reviewed May 6, 2023

View reviewed changes

pskowronek and others added 3 commits May 6, 2023 13:35

Dock/TaskBar icon status with jobs progress updates (PoC)

b64c42b

Dock/TaskBar icon progress slightly more accurate

484b45f

Dock/TaskBar icon progress - addressed minor PR comments

9320265

pskowronek force-pushed the dock-icon-status-update branch from 3cf92b0 to 9320265 Compare May 6, 2023 11:59

pskowronek added 3 commits May 6, 2023 14:18

Dock/TaskBar icon progress - addressed minor PR comments 2

b6b3468

Dock/TaskBar icon progress - codestyle/reformat only

1e5df42

Dock/TaskBar icon progress - move jobs listener registration to Notif…

6c6270e

…ierProvider

pskowronek force-pushed the dock-icon-status-update branch 2 times, most recently from 1d76ae7 to 0b38fb0 Compare May 6, 2023 22:34

Dock/TaskBar icon progress - workaround for progress bar not visible …

9f70443

…via Taskbar

pskowronek force-pushed the dock-icon-status-update branch from 0b38fb0 to 9f70443 Compare May 7, 2023 11:51

pskowronek changed the title ~~Dock/TaskBar icon status with jobs progress updates (PoC)~~ Dock/TaskBar icon status with jobs progress updates May 7, 2023

ahadas reviewed May 8, 2023

View reviewed changes

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java Show resolved Hide resolved

package/readme.txt Outdated Show resolved Hide resolved

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java Outdated Show resolved Hide resolved

Dock/TaskBar icon progress - minor fixes after PR review

32cbf9f

ahadas reviewed May 9, 2023

View reviewed changes

mucommander-os-api/src/main/java/com/mucommander/desktop/DefaultDesktopAdapter.java Outdated Show resolved Hide resolved

pskowronek and others added 2 commits May 9, 2023 20:01

Dock/TaskBar icon progress - minor fixes after PR review

dc2f02d

revert change of 'jre' submodule

60c277d

ahadas approved these changes May 9, 2023

View reviewed changes

ahadas merged commit 9829d40 into mucommander:master May 9, 2023

Uh oh!

Dock/TaskBar icon status with jobs progress updates #823

Dock/TaskBar icon status with jobs progress updates #823

Uh oh!

Conversation

pskowronek commented Dec 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Dec 26, 2022

Uh oh!

ahadas commented Jan 3, 2023

Uh oh!

pskowronek commented Apr 26, 2023

Uh oh!

pskowronek commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahadas commented Apr 29, 2023

Uh oh!

ahadas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pskowronek commented May 6, 2023

Uh oh!

pskowronek commented May 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pskowronek commented May 6, 2023

Uh oh!

pskowronek commented May 6, 2023

Uh oh!

ghost commented May 6, 2023

Uh oh!

ghost commented May 6, 2023

Uh oh!

pskowronek commented May 7, 2023

Uh oh!

ghost commented May 7, 2023

Uh oh!

pskowronek commented May 7, 2023

Uh oh!

ahadas May 8, 2023

Choose a reason for hiding this comment

Uh oh!

pskowronek May 9, 2023

Choose a reason for hiding this comment

Uh oh!

pskowronek May 9, 2023

Choose a reason for hiding this comment

Uh oh!

ahadas May 9, 2023

Choose a reason for hiding this comment

Uh oh!

pskowronek May 9, 2023

Choose a reason for hiding this comment

Uh oh!

ahadas May 10, 2023

Choose a reason for hiding this comment

Uh oh!

ahadas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahadas commented May 8, 2023

Uh oh!

pskowronek commented Dec 26, 2022 •

edited

Loading

pskowronek commented Apr 28, 2023 •

edited

Loading

ahadas left a comment •

edited

Loading

pskowronek commented May 6, 2023 •

edited

Loading

ahadas left a comment •

edited

Loading