refactor(proto)!: simplify proto.Version#532
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 4634 4611 -23
=========================================
- Hits 4634 4611 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context of retrieving Major and Minor number of a Version is bound to the Version itself, so it's more make sense to have is as method instead of a public function. This way we don't bloat
protopackage with "unnecessary" function and constants.We also don't have the proper context regarding which version is valid and which ones are not. The version may be updated faster than we can catch up with it, so now we trust the users to enter a valid version themself.
Removed items:
Changed: