[charts] Handle domain edge cases with filterMode: 'discard'
#19199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-19199--material-ui-x.netlify.app/ Bundle size report
|
CodSpeed Performance ReportMerging #19199 will improve performances by 8.62%Comparing Summary
Benchmarks breakdown
Footnotes |
JCQuintas
reviewed
Aug 18, 2025
Comment on lines
82
to
84
| const skipAxisRendering = position === 'none'; | ||
| const skipTickRendering = | ||
| (isScaleBand && domain.length === 0) || (!isScaleBand && domain.some(isInfinity)); |
There was a problem hiding this comment.
Can't we simply revert all these axis changes? It seems unnecessary, and would technically create a breaking change, wouldn't it simply work as it currently does if we remove them?
There was a problem hiding this comment.
It isn't unnecessary.
Without it, a zoomed area without any data points will hide the axis:
Screen.Recording.2025-09-09.at.08.57.51.mov
With it, only the ticks will be hidden. The axis will still render:
Screen.Recording.2025-09-09.at.08.58.17.mov
would technically create a breaking change
That's true, but I think we can work around that. I'll try to see what I can do.
filterMode: 'discard'filterMode: 'discard'
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
07f0ed3 to
71c58ac
Compare
5183d1c to
4d97569
Compare
e4deca7 to
3893f66
Compare
alexfauquette
approved these changes
Sep 10, 2025
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18999.
Handle domain edge cases with
filterMode: 'discard'.Screen.Recording.2025-08-15.at.15.42.47.mov
A consequence of this change is that we'll now render the axis line when there's no data:
If that isn't acceptable, we can add a special case for it.