Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[charts] Simplify gestures by removing bindings #19767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

[charts] Simplify gestures by removing bindings #19767

merged 1 commit into from
Sep 30, 2025

Conversation

@JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Sep 30, 2025

Removes some unnecessary .binds

@JCQuintas JCQuintas requested a review from a team September 30, 2025 11:58
@JCQuintas JCQuintas self-assigned this Sep 30, 2025
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Sep 30, 2025
@mui-bot
Copy link

mui-bot commented Sep 30, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19767--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts ▼-243B(-0.07%) ▼-38B(-0.04%)
@mui/x-charts-pro ▼-243B(-0.06%) ▼-41B(-0.03%)
@mui/x-charts-premium ▼-243B(-0.06%) ▼-36B(-0.03%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a2a3e83

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #19767 will not alter performance

Comparing JCQuintas:remove-bindings (a2a3e83) with master (943e431)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (cf6e816) during the generation of this report, so 943e431 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@JCQuintas JCQuintas enabled auto-merge (squash) September 30, 2025 12:13
@JCQuintas JCQuintas merged commit 8562aef into mui:master Sep 30, 2025
25 checks passed
@JCQuintas JCQuintas deleted the remove-bindings branch September 30, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

Assignees

@JCQuintas JCQuintas

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JCQuintas @mui-bot @bernardobelchior