[docs] Add scatter chart with linear regression demo #19900
Conversation
e75e9d7 to
017ab99
Compare
|
Deploy preview: https://deploy-preview-19900--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
| See the [Composition—clipping](/x/react-charts/composition/#clipping) for more info. | ||
| ::: | ||
|
|
||
| ### Regression line |
There was a problem hiding this comment.
Placed this under composition because it requires composition, but not sure if it's the best place.
There was a problem hiding this comment.
Another option is to move it into the scatter-demo page. You might get more space to describe the different feature you used
There was a problem hiding this comment.
I was under the impression we wanted to remove the demo pages, isn't that right? That's why I placed it here
There was a problem hiding this comment.
We're not removing individual demo pages. I think this demo placed under Composition is fine, any new demo can go in the demo page.
| maximumFractionDigits: 0, | ||
| }); | ||
|
|
||
| export default function ScatterRegressionLine() { |
There was a problem hiding this comment.
This is looking very bland 😅 any improvement suggestions would be gladly accepted!
There was a problem hiding this comment.
Maybe a softer red or decreased opacity.
Maybe add a vertical dashed line where the line exits the chart?
There was a problem hiding this comment.
If you want a better red, you can pick the one from rainbowSurgePalette:
isLightTheme ? '#FA4F58' : '#F35865'
CodSpeed Performance ReportMerging #19900 will not alter performanceComparing Summary
Footnotes |
Related to #19869.
Add scatter chart with linear regression demo.