FIX(server): Add missing line breaks to --help output #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Jan 17, 2022
There was a problem hiding this comment.
The commit type should be FIX as FORMAT is usually only used for formatting the source code itself (which is never visible from the running application) whereas this fixes an issue with the actual program's output.
And the scope should be server and not murmur (we are in the process of deprecating the term "murmur").
So overall it should be FIX(server): ...
Signed-off-by: Felix Singer <[email protected]>
|
Thanks for the clarification! |
Krzmbrzl
approved these changes
Jan 17, 2022
|
No problem :) |
|
Are you planning to backport this to the 1.4.x branch? |
|
Given that this fixes a bug, yes a backport is due |
|
Thanks for fixing this 👍 |
|
Great, thanks :) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks