Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Backport "Merge PR #5646: FIX(server): Improve rememberchannelduration compare logic" to 1.4.x#5652

Merged
Krzmbrzl merged 1 commit intomumble-voip:1.4.xfrom
Krzmbrzl:backport/1.4.x/pr-5646
May 8, 2022
Merged

Backport "Merge PR #5646: FIX(server): Improve rememberchannelduration compare logic" to 1.4.x#5652
Krzmbrzl merged 1 commit intomumble-voip:1.4.xfrom
Krzmbrzl:backport/1.4.x/pr-5646

Conversation

@Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented May 8, 2022

Backport

This will backport the following commits from master to 1.4.x:

Questions ?

Please refer to the Backport tool documentation

The previous implementation of rememberchannelduration (mumble-voip#4147)
acknowledged the unreliability of the last_disconnect database
field. It used a workaround to set the last_disconnect field
to NULL for every user on every start of the mumble server.
However, with a default behavior for NULL, this created the
unintended side-effect that rememberchannel was erroneously
used for every user on their first connection after a server
restart.

This new implementation reverts the workaround of mumble-voip#4147 and
uses the last_active database field to check if last_disconnect
is reliable. If last_disconnect is unreliable, it will now use
the server uptime and compare it to rememberchanneduration.
We expect last_disconnect to be unreliable when the server
was shut down while clients are still connected.

Fixes mumble-voip#5639

(cherry picked from commit ccbf407)
@Krzmbrzl Krzmbrzl merged commit 7886cc8 into mumble-voip:1.4.x May 8, 2022
@Krzmbrzl Krzmbrzl deleted the backport/1.4.x/pr-5646 branch November 9, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants