Walkthrough

• File updated: src/murmur/main.cpp.
• Formatting change: adjusted spacing in a static_cast expression.
• CLI handling modified: on successful CLI parse/handling, the code now also prints to standard output, explicitly sets options.quit = true, and returns.
• Control flow adjusted by adding a second conditional branch for the success path that performs stdout printing and triggers quit/return.
• Failure path continues to log via qWarning and return early.
• No changes to exported/public signatures.

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

All checks have passed and the feedback from CodeRabbit has been address.
The --help now prints to stdout and returns proper exit codes.

May someone please approve the workflow and review for merging.
Thank you!

This fixes the problem. Out of curiosity, can you explain why this change was necessary in mumble-server, but not the mumble client?

This fixes the problem. Out of curiosity, can you explain why this change was necessary in mumble-server, but not the mumble client?

Well my thought process was that since the problem was occurring on the mumble-server i looked at the main.cpp file of it and since you guys mentioned it was working one person but not for another so I figured maybe there was a something/removed.

And i noticed that since the addition to CLI11 we were having this problem so I figured that was it.

I didn't think about the mumble-client since the problem was for the mumble-server command flag

This fixes the problem. Out of curiosity, can you explain why this change was necessary in mumble-server, but not the mumble client?

Well my thought process was that since the problem was occurring on the mumble-server i looked at the main.cpp file of it and since you guys mentioned it was working one person but not for another so I figured maybe there was a something/removed.

And i noticed that since the addition to CLI11 we were having this problem so I figured that was it.

I didn't think about the mumble-client since the problem was for the mumble-server command flag

This entirely misses the point of my question. I know that there was a problem with mumble-server and not with mumble-client, since I was the one who reported the issue.

I want to know (without digging into it myself, because otherwise I could have done this entire MR myself), why the implementation before your PR was working for the client but not the server. If you look at both implementations you will find that they are almost identical (with regards to the CLI parsing). So why was this broken in the first place?

This fixes the problem. Out of curiosity, can you explain why this change was necessary in mumble-server, but not the mumble client?

Well my thought process was that since the problem was occurring on the mumble-server i looked at the main.cpp file of it and since you guys mentioned it was working one person but not for another so I figured maybe there was a something/removed.
And i noticed that since the addition to CLI11 we were having this problem so I figured that was it.
I didn't think about the mumble-client since the problem was for the mumble-server command flag

This entirely misses the point of my question. I know that there was a problem with mumble-server and not with mumble-client, since I was the one who reported the issue.

I want to know (without digging into it myself, because otherwise I could have done this entire MR myself), why the implementation before your PR was working for the client but not the server. If you look at both implementations you will find that they are almost identical (with regards to the CLI parsing). So why was this broken in the first place?

In the mumble client main.cpp there was no custom message handler (qInstallMessageHandler) and was using the default Qt message handler. Whereas in the mumble-server main.cpp that custom handler was called
before the cli parsing while detach was true so we had buffering.

In the mumble client main.cpp there was no custom message handler (qInstallMessageHandler) and was using the default Qt message handler. Whereas in the mumble-server main.cpp that custom handler was called before the cli parsing while detach was true so we had buffering.

Thanks for the explanation. I see it now:

We do qInstallMessageHandler for the server before parsing the CLI options. Our message handler logs to syslog and not to stdout/stderr.

While we do qInstallMessageHandler after the parsing of CLI options for the client when initializing the logger. And I think our client handler/logger logs to multiple places including stdout/stderr anyway.

The only things missing for this PR are

• We want the exit code fix for the client, too. As stated above.
• The code formatting is not quite correct. Please check the PR-Check CI job log or use clang-format in version 10 to fix this.
• In the end we want 2 commits in this PR. One for the mumble-server cli output fix. And one for fixing the exit code in both server and client. Look up "git interactive rebase" to get an idea on how it is done.

If you have any further questions, feel free to ask

The only things missing for this PR are

* We want the exit code fix for the client, too. As stated above.

* The code formatting is not quite correct. Please check the PR-Check CI job log or use clang-format in version 10 to fix this.

* In the end we want 2 commits in this PR. One for the mumble-server cli output fix. And one for fixing the exit code in both server and client. Look up "git interactive rebase" to get an idea on how it is done.

If you have any further questions, feel free to ask

I used clang-format version 18 since i couldn't get the older version. I hope it still has the proper formatting, if not please notify and ill change it manually right away.

I used clang-format version 18 since i couldn't get the older version. I hope it still has the proper formatting, if not please notify and ill change it manually right away.

We are happy, if the CI is happy. For now please include the formatting fix in your existing 2 commits.

I used clang-format version 18 since i couldn't get the older version. I hope it still has the proper formatting, if not please notify and ill change it manually right away.

We are happy, if the CI is happy. For now please include the formatting fix in your existing 2 commits.

Can you explain what you meant by CI? I didn't get it.
And just to be sure I need to combine the 2 commits into 1 like squash them?

Can you explain what you meant by CI? I didn't get it.

CI is short for "continuous integration". These are the builds and checks that are run for every commit (on GitHub they are listed here under "checks". In order for your PR to be accepted all CI runs (checks) need to pass.

And just to be sure I need to combine the 2 commits into 1 like squash them?

You'll have to disentangle your changes first. To do that, squash all three of your commits and then do a git reset HEAD ~1 to "uncommit" the combined commit (the result of the squash). Now git status will show you the changed files. All those files need to be formatted via clang-format. Now, use git add -p to add only those changes related to the fix of the CLI output and commit them. Then add the remaining changes (related to the exit code fix) and commit those (note that this commit should have TYPE FIX(client, server) as both components are affected by this).

Thank you very much for fixing this 🎉

Thank you very much for fixing this 🎉

Thank you for allowing to work on it and guiding me through the process!!