Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix linting pre commits: exit if any linting step fails #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix linting pre commits: exit if any linting step fails #10

merged 3 commits into from
Aug 30, 2023

Conversation

@linakrisztian
Copy link
Contributor

@linakrisztian linakrisztian commented Aug 30, 2023 •
edited
Loading

  • Exit if any linting step failed
  • Print which linting step(s) failed

mmacata
mmacata approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more elegant to use something like set -e or set -o pipefail?
(Might not work because some steps in between might be allowed to fail, just a suggestion to think about)

@anikaweinmann
Copy link
Member

Wouldn't it be more elegant to use something like set -e or set -o pipefail? (Might not work because some steps in between might be allowed to fail, just a suggestion to think about)

I like to see all the linting errors at once, so that you can fix them all at one time before trying a next commit.

@linakrisztian linakrisztian merged commit 9257374 into main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmacata mmacata mmacata approved these changes

@anikaweinmann anikaweinmann anikaweinmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linakrisztian @anikaweinmann @mmacata