-
Notifications
You must be signed in to change notification settings - Fork 3
Porting Anvilock over to C++23 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nots1dd
wants to merge
43
commits into
main
Choose a base branch
from
unstable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting starts for Anvilock to C++ on the "unstable" branch.
Removed Smart pointers for Wayland objects and other members, will introduce them later as the porting goes smoother
Anvilock from this commit on shall follow this: HEADERS -> Forward decl, namespaces, structs and prototypes only SOURCE FILES -> HEADER's implementations
Merged
Now EGL is initialized and works just like Anvilock's C version on main branch.
Coding practice from now on dictates the use of ifndef and define directives instead of just using pragma once for headers.
…debase This commit is a step towards a more type safe codebase. All errors (including conversions, double promotion, etc.) are treated as errors.
This is a very naive way of doing it, in the future ideally this should be async to avoid blocking time texture rendering.
…g of widgets Goal for this is to a more structured way of maintaining widgets at compile time only.
For better directory naming heuristics + makes life easier for a global build in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current codebase for Anvilock is written in C and although it was written with good intention of making it modular and robust, it's lifetime practically didn't seem sustainable enough especially considering that I am bad at writing good and safe C code.
The branch
unstableis meant for the complete rewrite and porting of Anvilock in modern C++ (>= C++20). The main aim aside from the advantages of C++ is to make it more maintainable and have a more modular project that eventually is capable of:The port of Anvilock to C++ currently for this draft should aim to do the following:
config.tomlbetter