feat: provide chart name in myks context data #545
Conversation
WalkthroughA new Helm chart context integration was introduced, involving updates to the data schema, templating, vendir configuration, and Argo CD application definitions. New configuration files and templates were added to support the rendering and management of Helm chart resources, with the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ArgoCD
participant Myks
participant YTT
participant Helm Chart
User->>ArgoCD: Triggers Application sync
ArgoCD->>Myks: Initiates rendering for helm-myks-context
Myks->>YTT: Calls ytt with myks.context.helm.chart set
YTT->>Helm Chart: Renders chart with provided context
Helm Chart-->>YTT: Returns rendered YAML
YTT-->>Myks: Outputs merged YAML
Myks-->>ArgoCD: Supplies manifest for deployment
ArgoCD-->>User: Deploys resources and reports status
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
examples/integration-tests/rendered/argocd/mykso-dev/app-helm-myks-context.yaml (2)
14-18: Prefer HTTPS repo URL for smoother CI & fewer credentials hasslesUsing an SSH-style
repoURL([email protected]:...) forces Argo CD to depend on an SSH deploy key (and makes local “dry-runs” harder). An HTTPS URL with a read-only PAT/token (or even no auth for public repos) usually simplifies integration-test pipelines and avoids host-key verification issues.- repoURL: [email protected]:mykso/myks.git + repoURL: https://github.com/mykso/myks.git
23-25: Consider adding explicit labels/annotations when auto-creating the namespace
CreateNamespace=truewill create a bare namespace; any labels/annotations required by network-policies, cost-allocation, etc., won’t be applied.
If the namespace needs metadata, declare it as a separate manifest or use the newerNamespacesync-wave feature.examples/integration-tests/rendered/envs/mykso-dev/helm-myks-context/rendering-helm-test-chart-name.yaml (1)
6-11: Path consistency: verifyprototypereference
prototype: prototypes/helm-myks-contextis relative. In several earlier prototypes the path lives underexamples/integration-tests/prototypes/…. If the rendering engine resolves paths relative to repo-root, this will 404.- prototype: prototypes/helm-myks-context + prototype: examples/integration-tests/prototypes/helm-myks-contextDouble-check the lookup rules before merge.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
examples/integration-tests/envs/dev/env-data.ytt.yaml(1 hunks)examples/integration-tests/prototypes/helm-myks-context/helm/test-chart-name.yaml(1 hunks)examples/integration-tests/prototypes/helm-myks-context/vendir/base.ytt.yaml(1 hunks)examples/integration-tests/rendered/argocd/mykso-dev/app-helm-myks-context.yaml(1 hunks)examples/integration-tests/rendered/envs/mykso-dev/helm-myks-context/rendering-helm-test-chart-name.yaml(1 hunks)internal/myks/assets/data-schema.ytt.yaml(1 hunks)internal/myks/render.go(3 hunks)
🔇 Additional comments (7)
examples/integration-tests/envs/dev/env-data.ytt.yaml (1)
18-18: LGTM! Integration test addition follows established pattern.The new application entry correctly integrates the helm-myks-context prototype for testing the chart name context feature.
internal/myks/assets/data-schema.ytt.yaml (1)
149-152: LGTM! Schema extension is well-structured and documented.The helm context schema addition follows established patterns and provides a logical structure for helm-related context data. The comment clearly explains the purpose of the chart field.
examples/integration-tests/prototypes/helm-myks-context/helm/test-chart-name.yaml (1)
1-4: LGTM! Test template is appropriately minimal and functional.The ytt template correctly demonstrates accessing the myks.context data, which validates the chart name context feature integration.
examples/integration-tests/prototypes/helm-myks-context/vendir/base.ytt.yaml (1)
1-12: LGTM! Vendir configuration follows established patterns.The configuration properly manages chart dependencies for the integration test setup, with appropriate path references to the test chart.
internal/myks/render.go (3)
166-166: LGTM! Core implementation correctly passes chart name to ytt.The ytt argument construction properly passes the helm chart name as
myks.context.helm.chart, enabling templates to access the chart name during rendering.
190-190: LGTM! Comment accurately describes the enhanced functionality.The updated comment clearly explains that the values files are rendered with the new helm chart context injected.
207-207: LGTM! Comment clarifies the values merging process.The comment appropriately explains the merge behavior that simulates how Helm combines values files.
Summary by CodeRabbit
New Features
Documentation