-
Notifications
You must be signed in to change notification settings - Fork 3
chore(main): release 4.11.4 #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new 4.11.4 release entry to CHANGELOG.md (dated 2025-09-22) describing a Golang dependency bug fix and updates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)version.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test / test
🔇 Additional comments (1)
version.txt (1)
1-1: LGTM: version bump to 4.11.4. CHANGELOG has an entry for 4.11.4 dated 2025-09-19; no stale 4.11.3 references found.
CHANGELOG.md
Outdated
| ## [4.11.4](https://github.com/mykso/myks/compare/v4.11.3...v4.11.4) (2025-09-19) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **deps:** update golang dependencies (non-major) ([#605](https://github.com/mykso/myks/issues/605)) ([8c17243](https://github.com/mykso/myks/commit/8c1724339e2160ee4196d33bb72c94c32ebe3f06)) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
LGTM: new 4.11.4 section with compare link, date, and deps note.
Format and links look standard for release-please.
Optionally verify that links resolve:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Extract the top release header compare URL
compare_url="$(sed -nE '0,/^## \[[0-9.]+\]\((https:[^)]+)\)/s//\1/p' CHANGELOG.md)"
echo "Compare URL: $compare_url"
code="$(curl -s -o /dev/null -w '%{http_code}' -L "$compare_url")"
echo "HTTP $code (expect 200)"
# Extract the first commit URL in the new section
commit_url="$(sed -nE '0,/^\* .* \(([0-9a-f]{7,40})\)\)/{s/.*\(([0-9a-f]{7,40})\).*/https:\/\/github.com\/mykso\/myks\/commit\/\1/p;T;q}' CHANGELOG.md)"
echo "Commit URL: $commit_url"
code2="$(curl -s -o /dev/null -w '%{http_code}' -L "$commit_url")"
echo "HTTP $code2 (expect 200)"Length of output: 81
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file=CHANGELOG.md
if [ ! -f "$file" ]; then
echo "ERROR: $file not found" >&2
exit 2
fi
# Extract first release header line containing a compare link
header_line="$(awk 'match($0,/^## \[[^]]+\]\((https?:\/\/[^)]+)\)/){print; exit}' "$file" || true)"
echo "Header line: $header_line"
compare_url="$(printf "%s" "$header_line" | sed -nE 's/^## \[[^]]+\]\((https?:\/\/[^)]+)\).*/\1/p' || true)"
echo "Compare URL: $compare_url"
if [ -n "$compare_url" ]; then
code="$(curl -s -o /dev/null -w '%{http_code}' -L "$compare_url" || echo "000")"
echo "Compare HTTP $code (expect 200)"
else
echo "No compare URL extracted"
fi
# Extract section (from that header until next '## ' or EOF)
section="$(awk 'found{if(/^## /) exit; print} /^## \[[^]]+\]\(https?:\/\/[^)]+\)/{found=1; print; next}' "$file" || true)"
echo "Section first 20 lines:"
printf "%s\n" "$section" | sed -n '1,20p'
# Find first GitHub commit URL in the section
commit_url="$(printf "%s\n" "$section" | grep -oE 'https?://github.com/[^/]+/[^/]+/commit/[0-9a-f]{7,40}' | head -n1 || true)"
# Fallback: if commit URL not found, look for short hash indicators like [8c17243]
if [ -z "$commit_url" ]; then
commit_hash="$(printf "%s\n" "$section" | grep -oE '\[[0-9a-f]{7,40}\]' | head -n1 | tr -d '[]' || true)"
if [ -n "$commit_hash" ]; then
commit_url="https://github.com/mykso/myks/commit/$commit_hash"
fi
fi
if [ -n "$commit_url" ]; then
echo "Commit URL: $commit_url"
code2="$(curl -s -o /dev/null -w '%{http_code}' -L "$commit_url" || echo "000")"
echo "Commit HTTP $code2 (expect 200)"
else
echo "No commit URL found in section"
fiLength of output: 628
Fix: CHANGELOG compare link is broken (HTTP 404)
CHANGELOG.md — 4.11.4 header: compare URL v4.11.3...v4.11.4 returns HTTP 404; commit URL 8c17243 returns HTTP 200. Update the compare link or create/push the v4.11.4 tag so the compare link resolves.
🤖 Prompt for AI Agents
CHANGELOG.md around lines 3-9: the compare URL for v4.11.4
(https://github.com/mykso/myks/compare/v4.11.3...v4.11.4) 404s because the
v4.11.4 tag is missing or the compare path is incorrect; fix by either creating
and pushing the v4.11.4 Git tag to the remote so the compare URL resolves, or
update the compare link to a valid reference (e.g., compare against the commit
SHA or use the correct tag name) so the URL returns 200; ensure the header link
and any related URLs in this release note point to existing remote refs.
38a2856 to
1be1ca4
Compare
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
4.11.4 (2025-09-22)
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit