refactor: use globe config everwhere #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #192 +/- ##
==========================================
- Coverage 48.16% 48.05% -0.11%
==========================================
Files 26 26
Lines 2448 2466 +18
==========================================
+ Hits 1179 1185 +6
- Misses 1085 1097 +12
Partials 184 184 ☔ View full report in Codecov by Sentry. |
Zebradil
approved these changes
Dec 27, 2023
Co-authored-by: German Lashevich <[email protected]>
I tried to arrange in different groups. I will do a bit more refactoring in small batches to add more order 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that we are copying constants (folder names) onto too many places.
This MR just ensures that the globe constants are used everywhere.
A good next step would be to centralize filepath.Join with our patterns.