Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: decrease amount of git-related errors and warnings #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix: decrease amount of git-related errors and warnings #208

merged 3 commits into from
Jan 8, 2024

Conversation

@Zebradil
Copy link
Member

@Zebradil Zebradil commented Jan 8, 2024

  • fix(init): do not discover git environment
  • chore: go mod tidy
  • refactor: move git functions out of Globe
  • fix: handle no-git situation during init and in Smart Mode

Fixes #188

@Zebradil Zebradil linked an issue Jan 8, 2024 that may be closed by this pull request
[bug] myks init spits unreasonable errors in a fresh git repo #188
Closed
@codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (f5cf765) 48.20% compared to head (6bfae8f) 48.55%.
Report is 1 commits behind head on dev.

Files Patch % Lines
internal/myks/globe.go 59.25% 5 Missing and 6 partials ⚠️
internal/myks/git.go 78.78% 7 Missing ⚠️
internal/myks/smart_mode.go 0.00% 3 Missing ⚠️
cmd/init.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #208      +/-   ##
==========================================
+ Coverage   48.20%   48.55%   +0.34%     
==========================================
  Files          30       30              
  Lines        2587     2587              
==========================================
+ Hits         1247     1256       +9     
+ Misses       1148     1145       -3     
+ Partials      192      186       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zebradil Zebradil merged commit 6635495 into dev Jan 8, 2024
@Zebradil Zebradil deleted the 188-bug-myks-init-spits-unreasonable-errors-in-a-fresh-git-repo branch January 8, 2024 22:37
mykso-bot added a commit that referenced this pull request Jan 10, 2024
@mykso-bot
chore(release): 3.2.1 [skip ci]
f290af4 
## [3.2.1](v3.2.0...v3.2.1) (2024-01-10)

### Bug Fixes

* decrease amount of git-related errors and warnings ([#208](#208)) ([6635495](6635495))
This was referenced Oct 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] myks init spits unreasonable errors in a fresh git repo

2 participants

@Zebradil