-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: DRY collect functions #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
internal/myks/application.go:121
- [nitpick] The new conditional for collecting application data files omits logging on error, which could make debugging more difficult in case of failure. Consider logging the error before returning it.
if appDataFiles, err := a.collectTreeFiles(a.e.g.ApplicationDataFileName); err == nil {
if err := copyDir(staticFilesDir, staticFilesDestination, true); err != nil { | ||
log.Error().Err(err).Msg(a.Msg(StaticFilesStepName, "Unable to copy static files")) | ||
return err | ||
if staticFilesDirs, err := a.collectTreeFiles(a.e.g.StaticFilesDirName); err == nil { |
Copilot
AI
Apr 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The refactor removes the intermediate logging calls that provided visibility into the different static file sources. Consider re-adding at least one log statement to help diagnose issues in production.
Copilot uses AI. Check for mistakes.
7a21fcc
to
342d4b7
Compare
No description provided.