Thanks to visit codestin.com
Credit goes to github.com

Skip to content

633_metadata_export_to_tsv #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jun 13, 2022
Merged

633_metadata_export_to_tsv #694

merged 35 commits into from
Jun 13, 2022

Conversation

@InspiritedCoder
Copy link
Contributor

The project metadata can be exported and imported using a .tsv file;
If everything is OK, then the next step is to add manual import to metadata dialog;

InspiritedCoder and others added 10 commits April 22, 2022 16:59
@InspiritedCoder
Merge branch 'master' of https://github.com/mzmine/mzmine3
28cfe22
@InspiritedCoder
Merge branch 'master' of https://github.com/mzmine/mzmine3
a32a642
@InspiritedCoder @github-actions
Increment patch version
52f650c
@InspiritedCoder
Merge branch 'master' of https://github.com/mzmine/mzmine3
a9766d8
@InspiritedCoder
Merge branch 'master' of github.com:InspiritedCoder/mzmine3
f120429
@InspiritedCoder @github-actions
Increment patch version
fbfbb27
@InspiritedCoder
Merge branch 'master' of https://github.com/mzmine/mzmine3
9bac42b
@InspiritedCoder
Metadata export in .tsv format is added;
bc76638 
BUG: need to handle updating metadata table
after deleting a RawDataFile, otherwise it
will lead to bugs...
@InspiritedCoder
Metadata import is added;
67444dc 
BUG: sometimes the same parameters values are imported;
BUGFIX: need to update the metadata table when removing
        a RawDataFile;
@InspiritedCoder
Bug with updating the metadata table while removing
25fda4c 
a RawDataFile is fixed;
@robinschmid
Copy link
Member

Always use a private static final Logger logger ...
You can do this by adding a live template that shows up in the auto complete
image

private static final java.util.logging.Logger logger = java.util.logging.Logger.getLogger($CLASSNAME$.class.getName());

@robinschmid
Copy link
Member

Its getting there

@InspiritedCoder
Code was refactored;
9e20232 
Now import & export tasks are deligated to a class
implementing TableExportUtility interface; this way
MetadataTable can be in 2 states, depending on the format
of the table which is used to import/export the data (either long-table or wide-table);

The next step is to implement the WideTableExportUtility class;
@InspiritedCoder
MetadataColumns default values are added;
8bbd1ee 
There's an issue: idk whether we should display
defaut value if the parameteter is unset, or
we should just leave it empty;
@InspiritedCoder
WideTableExport format is added;
1925ef0 
Need to test it more and fix the
issue with the default values;
Also, pay attention to the fact that
if the parameter has no value assigned
to any RawDataFile then it would not be
exported in case of using LongTableExport format,
meanwhile it would be exported using WideTableExport.
@InspiritedCoder
Using of ConcurrentHashMap is now generalized;
d6d6e1f 
TODO: values in MetadataTable should be Optional;
this way I will fix an issue with saving null
values into a ConcurrentHashmap
@InspiritedCoder
Minor improvements;
3108805
@InspiritedCoder
Tooltips with parameters' descriptions are added;
810d0eb
@InspiritedCoder
Problem with tabs occuring in a description field is fixed;
788b502
@InspiritedCoder
Import & export dialogs are added;
2b17e06 
Need to add allerts which will clarify
the result of the import/export to the
user.
@robinschmid robinschmid marked this pull request as ready for review June 7, 2022 06:45
@robinschmid
Copy link
Member

The table looks great. Lets move the title column to the bottom just above the data. This is a bit more convenient for other people to parse
image

robinschmid
robinschmid reviewed Jun 7, 2022
View reviewed changes
@robinschmid
Copy link
Member

Merge the latest master

@robinschmid
Copy link
Member

Great thanks for the progress

@robinschmid robinschmid merged commit a89be23 into mzmine:master Jun 13, 2022
@InspiritedCoder InspiritedCoder deleted the 633_metadata_to_tsv branch June 15, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robinschmid robinschmid robinschmid left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@InspiritedCoder @robinschmid