Reuse rows and features in alignment if original featurelist will be removed #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used #2367 to compare the content of the feature lists before and after alignment and they equal for both reusing and copying features - this is in LC-MS. Will now also check GC-EI-MS |
a634b6f to
b82001f
Compare
…avoid-feature-copy
SteffenHeu
reviewed
Jan 28, 2025
| candidatesInAligned = FeatureListUtils.getCandidatesWithinRanges(mzRange, rtRange, | ||
| mobilityRange, baseRowsByMz, true); | ||
| } catch (Exception exception) { | ||
| System.out.println(exception); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If original feature list is set to be removed we can reuse the rows and features directly.
Cohort study with 500 samples and 21.000 aligned features went from 20 s --> 10 s. Memory should also greatly improve.
2x speed up