Handle recoverable unit attention codes #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I hope you're doing good!
I was working once again on writing QEMU-based end-to-end tests for EtchDroid (which is now easy since GH Actions has nested virtualization support!) and I spotted a new corner case.
If you plug in a USB drive via the QEMU monitor and immediately try to access it, i.e. within 2 seconds, the test unit ready command fails, with sense UNIT ATTENTION, ASC 0x29, ASCQ 0x00 ("Power on, reset, or bus device reset occurred").
I'm currently working around it with a sleep in the tests, but seeing your note I thought I'd work on making this type of failure recoverable.
I attempted to gather a bunch of unit attention conditions which should be recoverable and make them throw
NotReadyTryAgaininstead ofUnitAttentionso that the block device init method can give it another shot.