Don't autodetect SSE2 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, test __SSE2__ in the compiler. This doesn't make a difference on x86_64 as sse2 is always present. To enable sse2 for i686, one can add `-msse2` to `CFLAGS`.
|
This is two separate changes in one commit, right? I'm not challenging that, I'm just trying to make sure I follow what is being proposed here:
|
Yes. But it's really one change, not detecting sse2; and then there are no simd flags to leak. Since m4ri only uses sse2, there's nothing to loose here (x86_64 includes sse2). |
|
Ta! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, test SSE2 in the compiler.
This doesn't make a difference on x86_64 as sse2 is always present.
To enable sse2 for i686, one can add
-msse2toCFLAGS.This partly addresses #9. In the current version, simd flags would be leaked
from the build box, even unused ones as avx2 and avx512.