Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Faster manifold check #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Faster manifold check #4839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9048ad0
move mmanifold check code into analysis job
Floppy Oct 17, 2025
0f1af50
rewrite manyfold analysis to use assimp scene
Floppy Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions app/jobs/analysis/geometric_analysis_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ class Analysis::GeometricAnalysisJob < ApplicationJob
def perform(file_id)
# Get model
file = ModelFile.find(file_id)
return unless self.class.loader(file)
return unless file.loadable?
if SiteSettings.analyse_manifold
status[:step] = "jobs.analysis.geometric_analysis.loading_mesh" # i18n-tasks-use t('jobs.analysis.geometric_analysis.loading_mesh')
# Get mesh
mesh = self.class.load_mesh(file)
if mesh
scene = file.scene
if scene
status[:step] = "jobs.analysis.geometric_analysis.manifold_check" # i18n-tasks-use t('jobs.analysis.geometric_analysis.manifold_check')
# Check for manifold mesh
manifold = mesh.manifold?
# Check that all meshes are manifold
manifold = scene.meshes.map { manifold?(it) }.all?
Problem.create_or_clear(
file,
:non_manifold,
Expand All @@ -40,17 +40,30 @@ def perform(file_id)
end
end

def self.loader(file)
case file.extension.downcase
when "stl"
Mittsu::STLLoader
when "obj"
Mittsu::OBJLoader
private

def manifold?(mesh)
# Shortcut if there is nothing here
return true if mesh.num_faces == 0
# Detect manifold geometry in this object
edges = {}
# For each face, record its edges in the edge hash
mesh.faces.each do |face|
update_edge_hash face.indices[0], face.indices[1], edges
update_edge_hash face.indices[1], face.indices[2], edges
update_edge_hash face.indices[2], face.indices[0], edges
end
# If there's anything left in the edge hash, then either
# we have holes, or we have badly oriented faces
edges.empty?
end

def self.load_mesh(file)
# TODO: This can be better, but needs changes upstream in Mittsu to allow loaders to parse from an IO object
loader(file)&.new&.parse(file.attachment.read)
# Updates edge hash with the passed vertex indexes
# First, the reverse edge is searched for in the hash
# If found, it's removed as we've got a match
# If not, we record this edge in the hash
def update_edge_hash(v1, v2, edges)
return if edges.delete [v2, v1].pack("QQ")
edges[[v1, v2].pack("QQ")] = true
end
end
Loading