Gftp offical #1
Closed
Gftp offical #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ought to be replaced with the git sha1 if we get popular enough again
…newer glib versions Thanks to MATE, gstreamer, libvert and others for teaching me how this sorta works
…ions - Fix compilation on GCC6 and clang - Disable another unneeded deprecated gthread function
- Bring in current Brian's master - Modify new mac foregrond patch as per his recommendations
| typedef void (*_pCPSEnableForegroundOperation)(struct ProcessSerialNumber *psn, int val2, int val3, int val4, int val5); | ||
| typedef void (*_pSetFrontProcess)(struct ProcessSerialNumber *psn); | ||
|
|
||
| void gftp_gtk_mac_foreground_init( void ) |
Owner
There was a problem hiding this comment.
I would rename this function to be gftp_gtk_platform_specific_init instead of having mac in the name. I would also take mac out of the filename as well.
Contributor
Author
There was a problem hiding this comment.
ok sure thing. I will make the adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in the glib and gtk 1.x code removal