Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@markusdumke
Copy link
Owner

We are always happy to receive pull requests.

Please make sure you have read our coding guidelines:
https://github.com/mlr-org/mlr/wiki/mlr-Coding-Guidelines

This especially means that you have understood:

  • The style guide - our lintr will provide you feedback on this
  • How to run tests locally. Yes, travis will also run them for you, bad it is annoying to wait for this.
  • How to run R CMD CHECK locally. See point before.

Also it's helpful to get into direct contact with the suggested reviewers to get help, getting your PR merged.
You might want to join our slack at:
https://mlr-org.slack.com

larskotthoff and others added 26 commits September 22, 2018 19:24
* create liquidSVM learners

* add the necessary package

* include some tests (that are still failing (probably))

* add debug seed

* change parameter settings of liquidSVM
add the liquidSVM to the NEWS.md
* add toc to vignettes

* document
* add 'grouping' option

* account for grouping and blocking

* add tests

* use fixed instead of grouping

* hardcode iters when fixed = TRUE

* update tests and rename

* fix doc of makeResampleDesc

* also apply args blocking.cv and fixed to RepCV to fix blocking tests

* update tests

* update resample::blocking

* update documentation of arg 'fixed'

* grouping -> fixed

* set defaults for fixed and blocking.cv in makeResampleDesc

* fixed -> grouping

* explain why are doing a hard levels reset

* simplify code

* hand over new default args of makeResampleDesc

* update tests

* fix test expectations (handled by seed?)

* fixed and blocking.cv are official params and not just items

* fix doc

* Deploy from Travis build 12597 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432449836
Commit: af8a40d

* update docs from master

* update docs

* Deploy from Travis build 12603 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432635288
Commit: 312763e

* Deploy from Travis build 12602 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432635052
Commit: 7dc7606

* update vignette

* update help page

* update NEWS

* Deploy from Travis build 12624 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/434150919
Commit: 87e1195

* Deploy from Travis build 12622 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/434149614
Commit: 9f6ab3e

* Deploy from Travis build 12621 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/434148851
Commit: 50f51a4
* bernd is the cre ;)

* require latex

* Deploy from Travis build 12570 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/431379030
Commit: 3769036

* check pdf

* use rtools on appveyor

* Deploy from Travis build 12576 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/431876346
Commit: 5bdaad2

* add latex to appveyor

* update pandoc cache

* remove empty directory

* add src files to .Rbuildignore

* Deploy from Travis build 12578 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432185967
Commit: 541d718

* Deploy from Travis build 12579 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432191561
Commit: c1d7c35

* Deploy from Travis build 12581 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432204745
Commit: 572f1b7

* use 2017 image

* set c++ flag

* create makevars dir

* escape

* create file

* fix file.create

* next fix

* dont build vignettes

* Deploy from Travis build 12582 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432227385
Commit: 8cbe430

* set makevars

* Deploy from Travis build 12583 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432229044
Commit: 086f8ef

* Deploy from Travis build 12584 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432232330
Commit: 00a955c

* no rtools

* Deploy from Travis build 12585 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432235399
Commit: fd44c67

* Deploy from Travis build 12586 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432239094
Commit: fb89861

* Deploy from Travis build 12589 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432244196
Commit: 19c1aa1

* next makevars attempt

* try makevars.win

* Deploy from Travis build 12606 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432685495
Commit: 4850153

* Deploy from Travis build 12607 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432695490
Commit: e22a09b

* next cxx_std attempt

* next makevars attempt

* Deploy from Travis build 12608 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432808781
Commit: caa300a

* Deploy from Travis build 12609 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432813323
Commit: 7540dd1

* build pkg manually

* manual approach

* fix arg name

* find path

* Deploy from Travis build 12616 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/432939767
Commit: 75f0df9

* add comment

* update docs

* logo_navbar

* Deploy from Travis build 12618 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/433010681
Commit: c319147

* Deploy from Travis build 12617 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/433007650
Commit: 42ecb33

* merge docs

* Deploy from Travis build 12643 [ci skip]

Build URL: https://travis-ci.org/mlr-org/mlr/builds/434329962
Commit: 57eacd2
…ndices (mlr-org#2413)

* update getResamplingIndices()

* add explicit return statement

* add test checking translation of inner indices

* move purrr from suggests to imports and remove explicit importing notation

* no pipes

* remove duplicate fields

* fix description

* fix typo in tests

* set_names() needs to be one level higher

* update NEWS.md
@markusdumke markusdumke merged commit 6ac6c76 into feature_importance_for_h2o_learners Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants