Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@badener95
Copy link
Contributor

It will fall back to a date format according to the device locale in that case

@badener95
Copy link
Contributor Author

This reverts basically the changes from my last commit #362 except that the exception, that was causing crashes reported in #361 and #287 is caught an a fall back is provided. Personally I am not really sure if we should merge this, because this code assumes what is before and after the dash in the custom date format (that was already the case before my commit #362), but if you want to you can use all kinds of wonky stuff as custom date format (e.g. " - HH:mm" won't show any date in the widget [I know, nobody would use this format, I am just pointing out the flaws of this code]). But at least the crahses should be fixed and all the predefined formats work again for the widget.

@robinpaulson
Copy link
Contributor

Fixing crashes is a good thing, so I'm prepared to accept this pull. Could you take a look at this PR, let me know if there's any problems in accepting it also? #326

@robinpaulson robinpaulson merged commit 34088e9 into martykan:master Oct 10, 2019
kmantel added a commit to kmantel/forecastie that referenced this pull request Dec 29, 2023
kmantel added a commit to kmantel/forecastie that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants