Add a Scroll Bar #5304
Add a Scroll Bar #5304
Conversation
|
Thanks! I appreciate that it does more than a "regular" scroll bar by adding visual markers for selections. Of course some other text-editors/IDE offer much more with other kinds of markers such as git added/changed/removed lines, or info/warning/error diagnostics. But then you end up with a "3 lanes" scroll bars with a lot of infos which can be confusing. "There's a red mark at the beginning of the buffer : is it red because of git removed lined or red because it's an LSP error?" So here, I think you strike the right balance by only focusing on one of the core principle of Kakoune which is its multi-selections capabilities. |
unfortunately this method causes the scrollbar to potentially have a non-constant height. however this method has the nice property of scrolling the scrollbar past the end of the buffer, just like we do with padding.
|
Does doc/json_ui.asciidoc need to be updated with the changes to |
|
While looking over the code, I think this would be best organized as a new method of |
when the wrap highlighter is added, the scroll bar size will reflect how many line numbers are visible. if a wrapped line is effectively taking up a lot of the vertical space in the window, the scroll bar handle will be smaller to reflect that the user is viewing a smaller portion of the file relative to the number of lines in the file.
|
I've improved the calculation of the size of the scroll bar handle. It works well with the There is still a bug where when scrolling horizontally (which is not possible when the |
prior to this the height of the scrollbar could change even if the nubmer of visible lines was vixed.
734778c to
f224aea
Compare
|
@enricozb Could you update this to latest master? The merge conflicts have piled up a bit. ❤️ |
|
Also, @mawww is this something you are willing to consider merging? It is a great usability improvement. |
|
It's been a while since I've looked at this code, but I've merged master in and fixed the conflicts. It looks like a |
|
Just writing here, I think there's a small bug where (for some reason) the last (rightmost) char of the modeline is clipped, until we perform a resize. Here's a screenshot where the upper client has been resized after opening, but the bottom has not yet. |
|
I can confirm that I've seen this, but I don't have a reproduction. |
|
This consistently happens to me on every client creation, and is fixed after a resize. It's likely to do with some computation i wrote that isn't refreshed on changes to |
|
Fixed the incorrect dimension calculation, no longer requires a resize. Also updated to master once again. |
A scroll bar that also displays selection lines in the buffer.
This PR adds:
terminal_scroll_bartoui_options, which controls whether the scroll bar should show.ScrollBarGutterandScrollBarHandlefaces describing how to style the gutter and handle. The foreground of these faces will be the color of the characters used to display selection lines.Screenshots
Here is a recording with the default styling and config
Here is a recording with my personal styling and config:
I've tested this with both non-remote and remote clients.
Issues
I am not the biggest fan of the implementation. The computation of
Vector<LineCount> selection_lineshappens on every draw call. This is needed to serialize these locations forRemoteUIandJsonUI. This is also computed regardless if the scrollbar is enabled, which is unfortunate.I'm not sure what the appetite for adding something like this is, especially with my implementation. I saw there was a highlighter implementation (#2597) but did not honestly consider it. If we feel like this is best done as a highlighter I can investigate that approach as well.