Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

Conversation

@anoadragon453
Copy link
Member

We were getting the following harmless error in our logs:

[...] sygnal.gcmpushkin 109 - WARNING - The following configuration fields are not understood: {'max_connections'}

However this option is documented in the sample config:

sygnal/sygnal.yaml.sample

Lines 245 to 247 in 08318c8

# # This is the maximum number of connections to GCM servers at any one time
# # the default is 20.
# #max_connections: 20

and used in the codebase:

sygnal/sygnal/gcmpushkin.py

Lines 114 to 116 in 0672a84

self.max_connections = self.get_config(
"max_connections", DEFAULT_MAX_CONNECTIONS
)

So it seems like we just forgot to add it to this list while adding the option 🙂

(If you're wondering why inflight_request_limit isn't in this dict either, that's because it's shared across both APNs and GCM pushkin types :)

@anoadragon453 anoadragon453 requested a review from a team December 10, 2020 18:23
Co-authored-by: Patrick Cloke <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants