This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Update CONTRIBUTING.md #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instruction to install `libq-dev` on Ubuntu
callahad
suggested changes
Apr 1, 2021
There was a problem hiding this comment.
Thank you for the contribution! Looks mostly good, though I did have one comment inline and two small requests here. Please:
- Add a changelog file describing this work.
- Sign-off on your changes so we know we're allowed to use them.
Thank you again 👍
| ``` | ||
|
|
||
| ####*Note:* | ||
| Sygnal depends on the psycop database adapter for PostgreSQL. For the command above to succeed, you may first need to install the development headers for libpq, for example, by running `sudo apt install libpq-dev` on Ubuntu." |
There was a problem hiding this comment.
Can probably get rid of the '####' prefix since we're not really introducing a new heading here; more of an aside.
Also, it's psycopg2 not psycop 🙂
I did some testing and it's possible that people will need more than just libpq-dev; could you please suggest folks install libpq-dev python3-dev build-essential?
|
Closing; this is being replaced by #197 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instruction to install
libq-devon Ubuntu