This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Add entrypoint #341
Merged
Add entrypoint #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done. I wasn’t really sure where to put the changelog entry, please let me know if I should put it somewhere else. |
DMRobertson
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Thanks, but this needs to be in a changelog file, probably changelog.d/341.misc. See https://github.com/matrix-org/sygnal/tree/main/changelog.d for examples.
There was a problem hiding this comment.
Sorry, I hope it’s correct now.
There was a problem hiding this comment.
Thanks, that's perfect. One last thing: can you sign-off on your change? (Sorry to ask---I know it's a pain to have an extra formality to go through for a simple change like this)
There was a problem hiding this comment.
No problem, here you go!
Signed-off-by: Sylvain Fankhauser <[email protected]>
DMRobertson
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running Sygnal with the
sygnalcommand. Also it’s required to have it packaged with Nix’sbuildPythonApplication, which uses entrypoints to create the executables.