This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Change so that update group room visibility isn't an upsert #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebarnard1
approved these changes
Nov 8, 2017
| """Update room config in group | ||
| """ | ||
| PATH = "/groups/(?P<group_id>[^/]*)/room/(?P<room_id>[^/]*)" | ||
| "/config/(?P<config_key>[^/]*)$" |
Contributor
There was a problem hiding this comment.
Is this supposed to be unindented? I'm guessing yes, I just haven't seen this before
Member
Author
There was a problem hiding this comment.
Woops. I need to add brackets...
lukebarnard1
reviewed
Nov 9, 2017
| PATH = "/groups/(?P<group_id>[^/]*)/room/(?P<room_id>[^/]*)" | ||
| "/config/(?P<config_key>[^/]*)$" | ||
| PATH = ( | ||
| "/groups/(?P<group_id>[^/]*)/room/(?P<room_id>[^/]*)" |
Contributor
There was a problem hiding this comment.
oo spooky python string concatenation
Member
Author
|
FTR, the plan is to do a global s/visibility/m.visibility/ to namespace the settings, but I'll do that as a separate PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API of the form:
PUT /groups/:group_id/room/:room_id/config/:config_key, where currentlyconfig_keycan only bevisibility.The natural API shape here would still be to allow
PUT /groups/:group_id/room/:room_idas an upsert, but that isn't implemented.(This PR also fixes the fact that add room doesn't work over federation, hopefully)