increase test timeout from 40->50min #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 56.83% 56.83%
=======================================
Files 5 5
Lines 234 234
=======================================
Hits 133 133
Misses 65 65
Partials 36 36 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we saw in eventing, for some reason tests seem to take longer with 1.20 and there's been some timeouts in the tests.
https://github.com/knative/eventing/pull/4729/files#diff-8d196c4ce9b53dec57fab83c31e0f2a460d671683b19c3ef3d662003e1305d1cR185
Here at least seems like the 40 minutes was exceeded also:
https://github.com/mattmoor/mink/runs/1716380168?check_suite_focus=true
And looking at a few successful runs, the e2e eventing tests do hover around 40 minutes already:
https://github.com/mattmoor/mink/runs/1717176852?check_suite_focus=true