Thanks to visit codestin.com
Credit goes to github.com

Skip to content

composerisation of Mautic TPROD-147 #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RCheesley merged 18 commits into from
Mar 30, 2021
Merged

composerisation of Mautic TPROD-147 #9863

RCheesley merged 18 commits into from
Mar 30, 2021

Conversation

@nickveenhof
Copy link
Contributor

@nickveenhof nickveenhof commented Mar 29, 2021

Description:

This PR moves the plugins out of the codebase and allows Mautic to be installed with different ways. This PR ideally doesn't change the way people can install mautic, but it offers possibilities such as

composer create-project mautic/recommended-project:4.x-dev mauticcomposerproject --no-interaction

What is still open before this can get green light

Steps to test this PR:

  1. Load up this PR
  2. See if Mautic still works as expected
  3. Run composer update --with-dependencies, see if mautic still works as expecred

@nickveenhof
Allowing composer based installations and move plugins & themes to se…
03367f3 
…parate repositories. Also copying asset files to app/assets but keep duplicates in there for now
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 29, 2021
@RCheesley RCheesley added this to the 4.0-alpha milestone Mar 29, 2021
@RCheesley RCheesley added feature A new feature for inclusion in minor or major releases T2 Medium difficulty to fix (issue) or test (PR) labels Mar 29, 2021
@RCheesley RCheesley closed this Mar 30, 2021
@RCheesley RCheesley reopened this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #9863 (fe7fa1d) into features (8669c33) will increase coverage by 5.41%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             features    #9863      +/-   ##
==============================================
+ Coverage       39.34%   44.76%   +5.41%     
+ Complexity      34322    29024    -5298     
==============================================
  Files            2036     1838     -198     
  Lines          108497    95336   -13161     
==============================================
- Hits            42692    42673      -19     
+ Misses          65805    52663   -13142
Impacted Files Coverage Δ Complexity Δ
...bundles/IntegrationsBundle/Command/SyncCommand.php 98.14% <0.00%> (-0.36%) 8.00% <0.00%> (-1.00%)
app/bundles/CoreBundle/Form/Type/LookupType.php 100.00% <0.00%> (ø) 2.00% <0.00%> (-1.00%)
...dles/InstallBundle/Configurator/Step/CheckStep.php 7.44% <0.00%> (ø) 47.00% <0.00%> (+1.00%)
...les/LeadBundle/EventListener/CompanySubscriber.php 100.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
...serBundle/Security/SAML/Store/CredentialsStore.php 100.00% <0.00%> (ø) 12.00% <0.00%> (ø%)
...usBundle/Security/Permissions/FocusPermissions.php
...lugins/MauticFocusBundle/Form/Type/ContentType.php
...auticCrmBundle/Integration/DynamicsIntegration.php
...ticFullContactBundle/Services/FullContact_Name.php
...Bundle/Integration/Pipedrive/AbstractPipedrive.php
... and 193 more

dennisameling
dennisameling approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a clean installation using the web-based installer works! Uploading images also works. Also did a quick check on the changes in the composer.json file and it's looking good! THANKS! 🚀

image

@RCheesley RCheesley merged commit 823a23c into mautic:features Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dennisameling dennisameling dennisameling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed The PR contributors have signed the contributors agreement feature A new feature for inclusion in minor or major releases T2 Medium difficulty to fix (issue) or test (PR)

Projects

None yet

Milestone

4.0.0-alpha1

Development

Successfully merging this pull request may close these issues.

3 participants

@nickveenhof @dennisameling @RCheesley