Sort log entries chronologically before calling PutLogEvents. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issues maxbanton#32 and maxbanton#69 for more context.
maxbanton
approved these changes
Oct 6, 2019
holtkamp
reviewed
Oct 9, 2019
| usort($entries, static function (array $a, array $b) { | ||
| if ($a['timestamp'] < $b['timestamp']) { | ||
| return -1; | ||
| } elseif ($a['timestamp'] > $b['timestamp']) { |
Contributor
There was a problem hiding this comment.
Why use elseif here? if suffices due to the early return in line 264...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix.
See issues #32 and #69.
Chronological order of log entries is ensured before submission.
No.
The comparison logic is the fastest one still supported on PHP 5.6. The spaceship operator seems to be a little bit faster, but not available in PHP 5.