Improve tests stability #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This aligns the behavior with the [Eio] runner. - The makes tests more stable across os and os-distributions. If we need to debug the path resolution, we'll consider adding some special getters to access the full path. This is left as future work if ever needed.
- This helps in particular when testing under Macos, where the hg process may include warning lines like the following on stderr: > No entry for terminal type "unknown"; > using dumb terminal settings. This was encountered during tests run by [ocaml-ci].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some assorted changes to make the tests less brittle when run in various os/os-distribution context.
Also forces the latest version of OCaml (same as used in main CI) for the volgo-dev target, to ease maintenance.