-
Notifications
You must be signed in to change notification settings - Fork 0
Feature 2301 updated #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feature2301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the update, changes required in search.py, please check and update
src/search.py
Outdated
| def search_port1(): | ||
| search_port() | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove function search_port1() , start line 58 and end line 61.
Removed search_port1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can merge these changes.
After adding feature for 2301 , review 1 done, this is for review2