Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vinaynmcci
Copy link
Collaborator

After adding feature for 2301 , review 1 done, this is for review2

Copy link
Contributor

@vseenivasan vseenivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the update, changes required in search.py, please check and update

src/search.py Outdated
Comment on lines 58 to 61
def search_port1():
search_port()


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function search_port1() , start line 58 and end line 61.

Removed search_port1.
@vinaynmcci vinaynmcci requested a review from vseenivasan May 3, 2021 10:56
Copy link
Contributor

@vseenivasan vseenivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can merge these changes.

@vseenivasan vseenivasan merged commit 33876b7 into master May 3, 2021
@vseenivasan vseenivasan deleted the bugfix/bugfix_pep8standard branch May 26, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants