Collection of small fixes and perf. improvements #14
Conversation
| yTicks = ticks1D plotH (yNumTicks cfg) (ymin, ymax) True | ||
| baseLbl = List.replicate plotH pad | ||
|
|
||
| setAt :: [Text] -> Int -> Text -> [Text] |
There was a problem hiding this comment.
It's not a big deal, but this impl. is less efficient than it could be, because it traverses the input list multiple times:
- length traverses the spine of the list to determine the length
- take, drop and the two calls to
<>repeatedly traverse the initial segment of lengthiof the list to do their job.
So I'm just adding custom recursive function that only traverses the initial segment of length i once.
It DOES change semantics a bit compared to the first implementation of setAt
setAt row i v = take i row <> [v] <> drop (i + 1) row
which "inserts v in all cases" (even if the index is out of bounds of list indices) - which was probably not the indented behavior?
| , ("Class D", [65, 70, 72, 68, 75, 80, 73, 71, 69, 74, 77, 76]) | ||
| ] | ||
| defPlot{plotTitle = "Test Score Distribution by Class"} | ||
| defPlot{plotTitle = "Test Score Distribution by Class", xNumTicks = 4} |
There was a problem hiding this comment.
This was only showing the default 3 x labels, which makes one of the labels not appear and makes the demo look broken.
There was a problem hiding this comment.
I'm still having trouble with grid axes in general. Was thinking to rewrite parts of this when I get time.
| maximum' [] = 1 | ||
| maximum' xs = maximum xs | ||
|
|
||
| safeHead :: [a] -> Maybe a |
There was a problem hiding this comment.
Replaced this with equivalent function listToMaybe from base.
|
|
||
| grid8 = setGridChar grid7 xMid minRow '┬' (Just col) | ||
| grid9 = setGridChar grid8 xMid maxRow '┴' (Just col) | ||
| grid8 = setGridChar grid7 xMid minRow '┴' (Just col) |
There was a problem hiding this comment.
These chars were upside down (max should use ┬, min should use ┴)
| , ("Class D", [65, 70, 72, 68, 75, 80, 73, 71, 69, 74, 77, 76]) | ||
| ] | ||
| defPlot{plotTitle = "Test Score Distribution by Class"} | ||
| defPlot{plotTitle = "Test Score Distribution by Class", xNumTicks = 4} |
There was a problem hiding this comment.
This was only showing the default 3 x labels, which makes one of the labels not appear and makes the demo look broken.
Also the min/max characters are flipped.
The boxes don't look great, but I might improve their rendering in followup PR (by using "corner" box drawing chars).
There was a problem hiding this comment.
Yeah. I don't like the box plots. They are still here more as a gimmick.
| ( \acc (row, v) -> | ||
| setAt acc row (justifyRight left (yFormatter cfg (yEnv row) ySlot v)) | ||
| setAt acc row | ||
| . ellipsisize left |
There was a problem hiding this comment.
Adding call to ellipsisize here, which will truncate overly long labels on y axis, preventing them from breaking the chart by shifting everything to the right.
This is how it works now:
There was a problem hiding this comment.
Makes sense. Thus should be documented somewhere in the haddock.
There was a problem hiding this comment.
Will mention it in the next PR.
| cy = yDot `div` 4 | ||
| rx = xDot - 2 * cx | ||
| ry = yDot - 4 * cy | ||
| let (cx, rx) = xDot `divMod` 2 |
| ( \acc (row, v) -> | ||
| setAt acc row (justifyRight left (yFormatter cfg (yEnv row) ySlot v)) | ||
| setAt acc row | ||
| . ellipsisize left |
There was a problem hiding this comment.
Makes sense. Thus should be documented somewhere in the haddock.
| yTicks = ticks1D plotH (yNumTicks cfg) (ymin, ymax) True | ||
| baseLbl = List.replicate plotH pad | ||
|
|
||
| setAt :: [Text] -> Int -> Text -> [Text] |
No description provided.