patch undefined fchmod in windows #33
Conversation
|
Maybe you could create some wrapper? Binaries for windows are easily generated via MinGW. |
That's what I did, and how I discovered it.
Not an expert on windows/mingw. After adding that feature in Linux, I thought it was supported by mingw as I know p/lzip working in windows. Didn't realise that particular thing is absent there. While I was researching it last time I picked simplest one I could possibly find and understand. Will have a look but I can't promise it now. |
|
Hello @tansy - I added a commit, would you mind to check if this works es expected? |
|
I can confirm that it works, I mean, doesn't crash. Ed: setting/preserving timestamps doesn't work in MinGW. It works in Linux though. |
Trying to compile it under windows I got
undefined reference to 'fchmod'. I was surprised to discover that windows doesn't have that function, so I patched that with 0, so it didn't generate errors, though it won't work there.Patch come from Lzip where I got the idea of preserving file attributes in first place. If it's good enough there, it can be here.